Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: monotonicity maintained with high precision #6020

Closed
wants to merge 3 commits into from

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Aug 10, 2023

Closes: #XXX

What is the purpose of the change

Proving that with sdkosmomath.BigDec in tick conversion we still have monotonicity today

go test -timeout 2000s -
run TestMonotnicityAtPriceBounds github.com/osmosis-labs/osmosis/v17/x/concentrated-liquidity/math -count=1 -v
=== RUN   TestMonotnicityAtPriceBounds
Last value was monotonic:  true
Highest monotonic tick:  -162000000
smallestSupportedPrice:  0.000000000000000001000000000000000000
smallestSqrtPrice:  1.000000000000000000000000000000000000
--- PASS: TestMonotnicityAtPriceBounds (1095.45s)
PASS
ok      github.com/osmosis-labs/osmosis/v17/x/concentrated-liquidity/math       1095.526s

References

Testing and Verifying

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added unit test that validates ...
  • Added integration tests for end-to-end deployment with ...
  • Extended integration test for ...
  • Manually verified the change by ...

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@p0mvn
Copy link
Member Author

p0mvn commented Aug 18, 2023

Was made for demo purposes

@p0mvn p0mvn closed this Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant